Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 80: Default generic for epidist method #89

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Issue 80: Default generic for epidist method #89

merged 2 commits into from
Jun 6, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Jun 6, 2024 •
edited
Loading

Description

This PR closes #80.

I have tested that inst/s3-testing.R still runs fine.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes requested a review from seabbs June 6, 2024 13:49
@seabbs seabbs added this pull request to the merge queue Jun 6, 2024
Merged via the queue into main with commit 62c38d5 Jun 6, 2024
1 of 8 checks passed
@seabbs seabbs deleted the epidist-generic branch June 6, 2024 13:55
seabbs pushed a commit that referenced this pull request Jan 10, 2025
@athowes
Issue 80: Default generic for epidist method (#89)
02810be 
* The epidist.epidist_ltcad method can essentially become a generic

* Run document

Former-commit-id: 26513318e90128ad231f9bfe284106c69713e9c4 [formerly 7c18e7b2c05c7e4074e754d71b9f2e8e88a3be6e]
Former-commit-id: bc114bd44867be18f1c96368d1a8d6424f707998
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create default method for the epidist generic
2 participants
@athowes @seabbs