Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epinowcast/actions/install-cmdstan + pgdown as env object #51

Merged
merged 1 commit into from
May 21, 2024

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented May 21, 2024

Description

This PR is not linked to an issue. It overhauls the current CI to better match practice in epinowcast (mostly this is using our cmdstan action which has caching to speed up builds of CI) in order to begin looking at the issue with the pkgdown docs. With the same aim in mind it also adds saving the built website as an enviroment object (which is not standard epinowcast practice but should imo).

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@seabbs seabbs requested a review from athowes May 21, 2024 08:51
@seabbs
Copy link
Contributor Author

seabbs commented May 21, 2024

Its a bit in the weeds and ideally it would post a comment with a link or something but if you click on the pkgdown workflow and then on summary you should see something called website which is the built website.

Note that pkgdown is now working as expected despite me not having really touched it. Potentially this was a transient pkgdown issue which we see due to using the dev version (which we could think about if we really need but these kind of passing issues are kind of a feature of CI build systems sadly)

@seabbs
Copy link
Contributor Author

seabbs commented May 21, 2024

I triggered a build on main and yes it looks like the problem has cleared itself up≥

Copy link
Collaborator

@athowes athowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not used these functions before. If you have a chance, putting a brief response to my questions / clarifications would be helpful for me to learn what's going on. Other than that, happy to merge.

.github/workflows/R-CMD-check.yaml Show resolved Hide resolved
.github/workflows/R-CMD-check.yaml Show resolved Hide resolved
.github/workflows/pkgdown.yaml Show resolved Hide resolved
@seabbs seabbs added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit 03cac6f May 21, 2024
3 checks passed
@seabbs seabbs deleted the overhaul-ci branch May 21, 2024 10:03
seabbs added a commit that referenced this pull request Jan 10, 2025
Former-commit-id: 0dc33dac04ab352e6f3a1706d9cf7785f4b5cd2b [formerly 25ae9752694f79ee47a350b1195af5dfc3cfaaa4]
Former-commit-id: 01caacc5cf35674d43eac7099574be14bdaa1420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants