-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #442: Generalise to all brms distributions #459
Conversation
@kylieainslie I think this PR has put us in a place where we can think about testing mixtures using the brms |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #459 +/- ##
==========================================
- Coverage 94.24% 93.93% -0.31%
==========================================
Files 16 14 -2
Lines 469 429 -40
==========================================
- Hits 442 403 -39
+ Misses 27 26 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
The coverage gap we see here is not a new gap but showing up due to copying the function into a new location. In general the log likelihood tests are a bit weak but its also really hard to test. A potentially sensible candidate for a mocked test sometimes in the future |
f49f8c9
to
1b23148
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥳
Description
This PR closes #442. It adds function factories and uses
primarycensored
to generalise the latent model to allbrms
supported distributions.My outstanding uncertainty here is the naming and organisation of these functions. It would also be nice to still support custom families but I think that might need to be a new issue/stretch goal (as is quite edge case functionality anyway).
Checklist