Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #430: Proofread and update vignettes for release #455

Merged
merged 6 commits into from
Nov 21, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Nov 20, 2024

Description

This PR closes #430. I made a few edits to the vignettes but have left the issues outstanding about using the naive model (#403) and adding a figure about right truncation (#56).

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes changed the title Issue #430: Proofread and update vignettes for release Issue #430: Proofread and update vignettes for release Nov 20, 2024
@athowes athowes force-pushed the proofread-vignettes branch from 5a098b2 to 605448f Compare November 21, 2024 10:59
@athowes athowes marked this pull request as ready for review November 21, 2024 12:16
@athowes athowes requested a review from seabbs November 21, 2024 12:17
@seabbs seabbs force-pushed the proofread-vignettes branch from 5642088 to df7f219 Compare November 21, 2024 17:05
@seabbs seabbs enabled auto-merge (squash) November 21, 2024 17:05
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.09%. Comparing base (dd78619) to head (b8b0ab6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   94.09%   94.09%           
=======================================
  Files          15       15           
  Lines         457      457           
=======================================
  Hits          430      430           
  Misses         27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@athowes athowes force-pushed the proofread-vignettes branch from df7f219 to 06e634c Compare November 21, 2024 17:47
@seabbs seabbs force-pushed the proofread-vignettes branch from 06e634c to b8b0ab6 Compare November 21, 2024 18:04
@seabbs seabbs disabled auto-merge November 21, 2024 18:04
@seabbs seabbs merged commit ceffa60 into main Nov 21, 2024
5 checks passed
@seabbs seabbs deleted the proofread-vignettes branch November 21, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proofread vignettes
2 participants