Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #429: Add CDC as funder via logo and in DESCRIPTION #450

Closed
wants to merge 2 commits into from
Closed

Issue #429: Add CDC as funder via logo and in DESCRIPTION #450

wants to merge 2 commits into from

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Nov 16, 2024 •
edited
Loading

Description

This PR closes #429. Adds logo with clickable link to CDC site on the website, and it'll also show up in the package DESCRIPTION.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes

This comment was marked as outdated.

Sign in to view
@athowes
Copy link
Collaborator Author

athowes commented Nov 16, 2024 •
edited
Loading

Logo works:

image

Maybe make it bigger. Will wait on @kgostic approval here.

@athowes athowes marked this pull request as ready for review November 16, 2024 13:05
@athowes athowes requested review from kgostic and seabbs November 18, 2024 10:03
@athowes athowes changed the title Issue #429: Test for adding CDC as funder Issue #429: Add CDC as funder via logo and in DESCRIPTION Nov 18, 2024
@kgostic
Copy link
Collaborator

kgostic commented Nov 18, 2024

We're not going to be able to use the CDC logo so I'm going to close this!

@kgostic kgostic closed this Nov 18, 2024
@seabbs seabbs deleted the cdc-funder branch November 29, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgostic kgostic Awaiting requested review from kgostic

@seabbs seabbs Awaiting requested review from seabbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CFA contribution update
2 participants
@athowes @kgostic