Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 34: Refactor and infrastructure for filtering functions #42

Closed
wants to merge 7 commits into from

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented May 16, 2024

Description

This PR will close #34.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes force-pushed the filter-obs-refactor branch from 5b176fc to ff1ce29 Compare May 16, 2024 13:18
@athowes
Copy link
Collaborator Author

athowes commented May 17, 2024

Called with @seabbs about this:

  • Suggest to create new function which adds "time observed" to data
  • Suggest to have function for filtering data based on time observed
  • Discussion about whether "censoring" and "truncation" can happen in either order
  • Discussion about whether the package should be restricted to "days" (either as date or numeric)
    • At what point along processing should dates should be transformed to numeric
  • Suggest creating a mind map of functions in the package

@athowes athowes self-assigned this May 30, 2024
@athowes athowes added the soft block PRs that are softly blocked label Jun 12, 2024
@seabbs seabbs closed this Jul 8, 2024
@athowes athowes deleted the filter-obs-refactor branch August 28, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
soft block PRs that are softly blocked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor observation filtering functions
2 participants