Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #347: Use badge explicity for main branch #366

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Issue #347: Use badge explicity for main branch #366

merged 1 commit into from
Oct 2, 2024

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Oct 2, 2024

Description

This PR closes #347. It moves to using a badge that is explicitly for main vs depending on the defaults.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@seabbs seabbs enabled auto-merge (squash) October 2, 2024 15:51
@seabbs seabbs requested a review from athowes October 2, 2024 15:51
@athowes athowes changed the title Issue 347 Issue #347: Use badge explicity for main branch Oct 2, 2024
@seabbs seabbs merged commit 3d89cc1 into main Oct 2, 2024
7 checks passed
@seabbs seabbs deleted the fix-badge branch October 2, 2024 19:42
seabbs added a commit that referenced this pull request Jan 10, 2025
Former-commit-id: b00d1c225d0f6defb5a059896aac6b2ea0cb7062 [formerly a37a5195d27ebdbea1c45d933e8ab79cbaf3b133]
Former-commit-id: 8103fa710651bbf93e004eb0607c8e95c7f69ad1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge showing failing tests even though main is fine?
2 participants