Issue #338: Add double dispatch for epidist_family
#365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, looks like I branched off the transparency issue rather than main. Maybe this can be fixed anyway if that branch is merged. Edit: yes that worked fine. |
athowes
force-pushed
the
epidist-family-dispatch
branch
from
18d7d41 to
8ca944a
Compare
athowes
commented
Oct 3, 2024
seabbs
reviewed
Oct 4, 2024
seabbs
reviewed
Oct 4, 2024
seabbs
reviewed
Oct 4, 2024
|
It's a real bug! And the integration test with gamma caught it! Nice stuff. > family_gamma1 <- epidist_family(prep_obs, family = stats::Gamma)
> family_gamma2 <- epidist_family(prep_obs, family = stats::Gamma(link = "log"))
> family_gamma1$reparam
[1] "mu" "shape"
> family_gamma2$reparam
[1] "mu" "shape"
> family_gamma1$family
[1] "custom"
> family_gamma2$family
[1] "custom"(Bug is that it's not doing the reparam right. Edit: should be fixed) |
|
I think this is in a good place, I expect CI to hopefully pass this time. Then it remains to improve the documentation and tests a bit and iron out the discussion points above. |
|
Needs a redoc and work on the gamma method for reparam to pass checks |
…eparameterisation, the rest is the same for all families
…ame, document and lint
seabbs
force-pushed
the
epidist-family-dispatch
branch
from
cfff3df to
a0fad1f
Compare
seabbs
reviewed
Oct 7, 2024
seabbs
reviewed
Oct 7, 2024
seabbs
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This draft PR will close #338. It refactors the structure of
epidist_family:epidist_family_modelS3 to dispatch on the "model specific parts" of the family.add_dpar_infohelper to put thedparinformation other thanmuthere conveniently for use inepidist_family_modelepidist_family_reparamto perform the only family specific hard coded part: reparam to line upbrmsand Stanepidist_familyto call these nicer modular functionsWe have added a new issue to decide how to export functions in future (including those introduced by this PR): #79
Checklist