Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #319: Fixes to Ebola vignette sex-district figures #326

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Sep 13, 2024

Description

This PR closes #319.

As well as making the figure bigger I:

  • Fixed a bug with after_stat and facet_grid giving wrong density histograms
  • Recoded the districts to put a new line in two word names for the figure
  • Fixed some issues with the vignette title

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes marked this pull request as ready for review September 13, 2024 11:10
@athowes athowes requested a review from seabbs September 13, 2024 11:10
@seabbs seabbs merged commit 330d41c into main Sep 13, 2024
6 of 7 checks passed
@seabbs seabbs deleted the panel-c-small branch September 13, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panel C too small in Ebola vignette
2 participants