-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 245: Rename window_upr
to window
#315
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athowes
commented
Sep 12, 2024
athowes
commented
Sep 12, 2024
This was referenced Sep 12, 2024
athowes
force-pushed
the
rename-windows
branch
from
September 12, 2024 13:04
d552ecf
to
51b6a0f
Compare
seabbs
previously approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
===========================================
+ Coverage 28.49% 88.55% +60.06%
===========================================
Files 10 11 +1
Lines 565 402 -163
===========================================
+ Hits 161 356 +195
+ Misses 404 46 -358 ☔ View full report in Codecov by Sentry. |
seabbs
added a commit
that referenced
this pull request
Jan 10, 2025
* Rename window_upr to window * Run document and catch another instance * Update examples (and add missing save line!) * Remove _width here to be inline with other code * Update fits with proper package version --------- Co-authored-by: Sam Abbott <[email protected]> Former-commit-id: b89634c7c7d1a66783a5afb11559ca814c6e0aaf [formerly 97fcceae39ea1e653b6203243db1814fa47e06f6] Former-commit-id: b9a71d22f47d66417dcdd12cb7dcf3bcbb3245ab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #245. This change is inline with
primarycensordist
.Checklist