Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 245: Rename window_upr to window #315

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Issue 245: Rename window_upr to window #315

merged 6 commits into from
Sep 12, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Sep 11, 2024

Description

This PR closes #245. This change is inline with primarycensordist.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes requested a review from seabbs September 12, 2024 09:35
@athowes athowes marked this pull request as ready for review September 12, 2024 09:35
seabbs
seabbs previously approved these changes Sep 12, 2024
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs merged commit d02c7c7 into main Sep 12, 2024
4 checks passed
@seabbs seabbs deleted the rename-windows branch September 12, 2024 13:39
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (fa1be26) to head (96e477d).
Report is 111 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #315       +/-   ##
===========================================
+ Coverage   28.49%   88.55%   +60.06%     
===========================================
  Files          10       11        +1     
  Lines         565      402      -163     
===========================================
+ Hits          161      356      +195     
+ Misses        404       46      -358     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

seabbs added a commit that referenced this pull request Jan 10, 2025
* Rename window_upr to window

* Run document and catch another instance

* Update examples (and add missing save line!)

* Remove _width here to be inline with other code

* Update fits with proper package version

---------

Co-authored-by: Sam Abbott <[email protected]>
Former-commit-id: b89634c7c7d1a66783a5afb11559ca814c6e0aaf [formerly 97fcceae39ea1e653b6203243db1814fa47e06f6]
Former-commit-id: b9a71d22f47d66417dcdd12cb7dcf3bcbb3245ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename swindow_upr and pwindow_upr
2 participants