-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 26: Create CI for GitHub pages website #31
Conversation
# Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help | ||
on: | ||
push: | ||
branches: [main] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't want the master stuff here
.github/workflows/pkgdown.yaml
Outdated
@@ -42,7 +49,7 @@ jobs: | |||
|
|||
- name: Deploy to GitHub pages 🚀 | |||
if: github.event_name != 'pull_request' | |||
uses: JamesIves/github-pages-deploy-action@v4.6.0 | |||
uses: JamesIves/github-pages-deploy-action@v4.5.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why role this back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know. I used usethis::use_pkgdown_github_pages()
and it automatically made these changes. Happy to revert this back forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes please do.
Any ideas on what I should do (/if I should be aiming) to fix my API issue @seabbs? |
The build failure shows the issue with the current It looks like it is due to the |
I believe I have fixed these three issues (version, remove master, add theme dependency [I also added pkgdown, as listed on |
The build failed this time due to no I have added this package to Suggests. It would be nice if there were a way I could test this without fixing where it fails one by one using checks. Let me know if there is a better way I can do it. |
This passed now, so perhaps can be reviewed / merged @seabbs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Nice one! Note we should start tracking issue resolution in the news file (see the pr checklist and epinowcast)
Description
This PR will close #26.
I have run
usethis::use_pkgdown_github_pages()
. I get the errorwhich I'm currently trying to fix (though could be a permission thing?).
Checklist