Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 251: Add favicons #252

Merged
merged 3 commits into from
Aug 22, 2024
Merged

Issue 251: Add favicons #252

merged 3 commits into from
Aug 22, 2024

Conversation

seabbs
Copy link
Contributor

@seabbs seabbs commented Aug 21, 2024 •
edited
Loading

Description

This PR closes #251

It runs build_favicons() as required (see https://pkgdown.r-lib.org/reference/build_favicons.html)

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@seabbs seabbs requested a review from athowes August 21, 2024 10:29
@seabbs seabbs changed the title Add favicons Issue 251: Add favicons Aug 21, 2024
@seabbs seabbs merged commit 4fc6680 into main Aug 22, 2024
7 checks passed
@seabbs seabbs deleted the run-build-favicon branch August 22, 2024 11:36
seabbs added a commit that referenced this pull request Jan 10, 2025
@seabbs
Issue 251: Add favicons (#252)
4987f7b 
* add favicons

* make the DESCRIPTION cleaner

* remove random space

Former-commit-id: 0cd3c4cd66eff9a767c50b773daf32c744d11e90 [formerly 59017148c24393547401d7b8ceede818e6f4b56c]
Former-commit-id: b63a00d3e61a629bf1b7d4f6531c5b646469a1ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@athowes athowes Awaiting requested review from athowes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build favicons error
1 participant
@seabbs