Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 156: Remove inaccurate text from README #173

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Issue 156: Remove inaccurate text from README #173

merged 1 commit into from
Jul 17, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Jul 17, 2024

Description

This PR closes #156.

I've removed any inaccurate text from the README.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes requested review from jamesmbaazam and seabbs July 17, 2024 09:46
seabbs
seabbs approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging we need an issue to add this back in upon the first release as it should be the preferred install method vs remotes

@seabbs seabbs added this pull request to the merge queue Jul 17, 2024
@athowes athowes mentioned this pull request Jul 17, 2024
Open
jamesmbaazam
jamesmbaazam approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@jamesmbaazam jamesmbaazam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 17, 2024
@seabbs seabbs merged commit 3d36696 into main Jul 17, 2024
7 checks passed
@seabbs seabbs deleted the readme-update branch July 17, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmbaazam jamesmbaazam jamesmbaazam approved these changes

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation not (yet) possible through runiverse
3 participants
@athowes @seabbs @jamesmbaazam