Issue 127: Check Stan code is valid syntax #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seabbs
reviewed
Jul 15, 2024
| skip_on_cran() | ||
| stancode <- epidist(data = prep_obs, fn = brms::make_stancode) | ||
| mod <- cmdstan_model(stan_file = write_stan_file(stancode), compile = FALSE) | ||
| expect_true(mod$check_syntax()) |
There was a problem hiding this comment.
Are the comments here an issue : https://github.com/epinowcast/epinowcast/blob/d957b21af07c7708d8ae28fc248fffe39d453828/.github/workflows/check-cmdstan.yaml#L67
The concern would be that brms has pedantic problems at some point and this then breaks out testing.
seabbs
reviewed
Jul 15, 2024
seabbs
approved these changes
Jul 15, 2024
seabbs
pushed a commit
that referenced
this pull request
Jan 10, 2025
Former-commit-id: ec3b20f99398556f041214e08052faff1087b961 [formerly 4a3bf2d82c5834efa6df8d9f5b846be6cef72338] Former-commit-id: 542597ab3df5302e3430f4cb075b6401e6577b0e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #127.
I have added an issue about the complexity with where the invalid code comes from #159.
Checklist