Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 151: data validation as S3 generic #152

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Issue 151: data validation as S3 generic #152

merged 4 commits into from
Jul 17, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Jul 12, 2024

Description

This PR closes #151.

I named it epidist_validate following convention of other generics in the package.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes requested a review from seabbs July 12, 2024 13:31
R/defaults.R Outdated Show resolved Hide resolved
R/defaults.R Outdated Show resolved Hide resolved
seabbs
seabbs previously approved these changes Jul 15, 2024
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seabbs seabbs self-requested a review July 15, 2024 12:48
@seabbs seabbs added this pull request to the merge queue Jul 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2024
@seabbs seabbs added this pull request to the merge queue Jul 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 17, 2024
@seabbs seabbs merged commit 76d91c2 into main Jul 17, 2024
7 checks passed
@seabbs seabbs deleted the validate-s3 branch July 17, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validate as S3 method
2 participants