Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 116: Missing roxyglobals #117

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Issue 116: Missing roxyglobals #117

merged 1 commit into from
Jun 20, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Jun 19, 2024

Description

This PR closes #116.

I have checked that I have all of them by searching for NULL in the GitHub repo. I don't think there would be any that would miss, but could be wrong (?).

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes requested a review from seabbs June 19, 2024 10:13
@athowes
Copy link
Collaborator Author

athowes commented Jun 19, 2024

@seabbs I have added an issue for #120 which I think is unrelated. Otherwise I think this PR should be fine

@athowes athowes self-assigned this Jun 20, 2024
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. Looks good.

@seabbs seabbs merged commit 290bdfb into main Jun 20, 2024
7 of 8 checks passed
@seabbs seabbs deleted the roxyglobals-tidy branch June 20, 2024 11:05
seabbs pushed a commit that referenced this pull request Jan 10, 2025
Former-commit-id: 9996416e1cd2f5247a95b9d052d32a94da1edf29 [formerly 73d22c45f66359a4f17e910e6f8c316f422856b0]
Former-commit-id: 443cacb87bacd32d454a749ef187c50500eee72e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use roxyglobals everywhere
2 participants