Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use brms style formula input #374

Closed
athowes opened this issue Oct 10, 2024 · 1 comment · Fixed by #396
Closed

Use brms style formula input #374

athowes opened this issue Oct 10, 2024 · 1 comment · Fixed by #396
Assignees
@athowes
Labels
high Required for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Oct 10, 2024

As discussed in #307 we could shift to using brms style formula input.

Current we require users to input something in brms::bf() format.

We think that what brms does is:

  1. Let users specify one formula then convert it to brms::bf() under the hood
  2. OR let users specify multiple formula, in which case then it must be in brms::bf() format already

We should 1. verify that this is in fact how brms handles things, 2. implement to match brms-style.
@athowes athowes self-assigned this Oct 10, 2024
@athowes athowes added the high Required for next release label Oct 10, 2024
@athowes
Copy link
Collaborator Author

athowes commented Oct 14, 2024

Waiting on #383 to start work on this.

@athowes athowes mentioned this issue Oct 18, 2024
Merged
9 tasks
seabbs pushed a commit that referenced this issue Oct 22, 2024
@athowes
Issue #374: Set default to mu ~ 1 as formula (#396)
cfeeadc 
* Add test of mu ~ 1 working

* Set mu ~ 1 as default

* Improve wording

* Redocument following merge

* Include test of brms::bf(mu ~ 1, sigma ~ 1) producing the same thing as mu ~ 1

* Reword to use mu ~ 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@athowes athowes

Labels
high Required for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #374: Set default to mu ~ 1 as formula epinowcast/epidist
1 participant
@athowes