Bug in filter_obs_by_obs_time

[athowes]

In PR #349 I failed to rename properly in filter_obs_by_obs_time.

It should have been:

filter_obs_by_obs_time <- function(linelist, obs_time) {
  linelist |>
    mutate(
      relative_obs_time = obs_time - .data$ptime,
      censored_obs_time = .data$obs_time - .data$ptime_lwr,
      censored = "interval"
    ) |>
    filter(.data$stime_upr <= .data$obs_time)
}

But I had:

filter_obs_by_obs_time <- function(linelist, obs_time) {
  linelist |>
    mutate(
      obs_time = obs_time - .data$ptime,
      censored_obs_time = .data$obs_time - .data$ptime_lwr,
      censored = "interval"
    ) |>
    filter(.data$stime_upr <= .data$obs_time)
}

[athowes]

So here:

1. censored_obs_time is not used anywhere in the code and I think we can get rid
2. censored = "interval" is also not used anywhere in the code and I think we can get rid

[athowes]

Also to note I think filter_obs_by_ptime is 1. not used anywhere in the code 2. likely buggy (it's untested like filter_obs_by_obs_time).

In #34 I proposed to merge these two functions but didn't get around to it. Perhaps look to do that?

Perhaps easy to write again from scratch rather than understand existing?

Edit: I think also as part of this issue should add testing for some "observe" functionality.