Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add common functions to namespace #341

Closed
athowes opened this issue Sep 18, 2024 · 1 comment · Fixed by #344
Closed

Add common functions to namespace #341

athowes opened this issue Sep 18, 2024 · 1 comment · Fixed by #344
Labels
high Required for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Sep 18, 2024

the common CLI functions are good examples of things we might want in the namespace as we use them a lot

Originally posted by @seabbs in #329 (comment)

Also could do this for checkmate functions and anything else which seems appropriate.

Am I right in thinking never to use @importFrom in the roxygen next to the function and always centralised?

@athowes athowes added the high Required for next release label Sep 18, 2024
@seabbs
Copy link
Contributor

seabbs commented Sep 18, 2024

Am I right in thinking never to use @importFrom in the roxygen next to the function and always centralised?

I think if we are importing something because it is used a lot in one function that could be a good arg for doing it next to the function but if its because we use it several times across functions it might be clearer to centralise. I don't think it makes much different as you can just look at the namespace so whatever you would rather and can keep track of

seabbs pushed a commit that referenced this issue Sep 19, 2024
* Put checkmate functions into NAMESPACE

* Put cli functions into NAMESPACE

* Add assert_numeric
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high Required for next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants