Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .data$var nearly always for safety #340

Closed
athowes opened this issue Sep 18, 2024 · 1 comment · Fixed by #348
Closed

Use .data$var nearly always for safety #340

athowes opened this issue Sep 18, 2024 · 1 comment · Fixed by #348
Labels
high Required for next release

Comments

@athowes
Copy link
Collaborator

athowes commented Sep 18, 2024

In terms of dplyr I beleive we should be using .data$var on the right handside nearly always for safety (see deving with dplyr guidance for pointers)

Originally posted by @seabbs in #329 (review)
@athowes athowes mentioned this issue Sep 18, 2024
Merged
9 tasks
@seabbs seabbs added the high Required for next release label Sep 18, 2024
@athowes
Copy link
Collaborator Author

athowes commented Sep 19, 2024

mutate(new_col = .data$old_col * 2)

@athowes athowes mentioned this issue Sep 19, 2024
Merged
9 tasks
seabbs pushed a commit that referenced this issue Sep 20, 2024
@athowes
Issue #340: Use .data$ in right hand side of dplyr for safety (#348)
7ee66a8 
* Put .data$ into mutate calls

* Add .data$ to filter

* obs_time is not a column!

* pfilt_t also now a row

* Regeneration globals
seabbs pushed a commit that referenced this issue Jan 10, 2025
@athowes
Issue #340: Use .data$ in right hand side of dplyr for safety (#348)
ff56715 
* Put .data$ into mutate calls

* Add .data$ to filter

* obs_time is not a column!

* pfilt_t also now a row

* Regeneration globals

Former-commit-id: 5e65cf10bc20b7c151d2becfdabcbb3f5ec36a53 [formerly be2198ac3a75659d12620f3a08e7cce267a7b616]
Former-commit-id: 035cb2d34a1046ef9071f8cc18c0d4b5ca5c2e92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
high Required for next release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #340: Use .data$ in right hand side of dplyr for safety epinowcast/epidist
2 participants
@seabbs @athowes