Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Added federated:id claim in token request #33

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

enrichman
Copy link
Member

@enrichman enrichman commented Jun 13, 2023

Fixes epinio/ui#246

This PR adds the federated:id scope to the token request (https://dexidp.io/docs/custom-scopes-claims-clients/#scopes)

Scope Description
federated:id ID token claims should include information from the ID provider. The token will contain the connector ID and the user ID assigned at the provider.

This scope is used from the Epinio server to understand which was the provider used to login and use this information to associate the right group with the proper role.

See https://github.com/epinio/epinio/pull/1865/files for the server implementation.

@enrichman enrichman added the kind/bug Something isn't working label Jun 13, 2023
@enrichman enrichman added this to the v1.9.0 milestone Jun 13, 2023
@enrichman enrichman requested a review from a team June 13, 2023 15:00
@enrichman enrichman self-assigned this Jun 13, 2023
Copy link

@thehejik thehejik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have built a testing image and verified according the reproducer mentioned in #246 and now I could get admin's role over UI dex login.

Testing image available on dockerhub thehejik/epinio-ui:dex-roles

@enrichman enrichman merged commit f7e7367 into main Jun 14, 2023
@thehejik
Copy link

thehejik commented Jul 4, 2023

Verified fixed in epinio v1.9.0-rc3 - all good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
Archived in project
Status: Done
Development

Successfully merging this pull request may close these issues.

Dex Role Mapping not working for Epinio UI
2 participants