Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UKHPI: updates ruby version and alpine version #456

Merged
merged 2 commits into from
Oct 8, 2024
Merged

UKHPI: updates ruby version and alpine version #456

merged 2 commits into from
Oct 8, 2024

Conversation

DanielCouzens
Copy link
Contributor

Updates UKHPI app to 1.7.6
Updates ruby to 2.7.8
Updates alpine 3.16

jonrandahl
jonrandahl requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor adjustment on version cadence requested in comment, otherwise LGTM! 👍

CHANGELOG.md Outdated Show resolved Hide resolved
app/lib/version.rb Outdated Show resolved Hide resolved
@DanielCouzens DanielCouzens marked this pull request as ready for review October 7, 2024 12:57
@DanielCouzens DanielCouzens self-assigned this Oct 7, 2024
jonrandahl
jonrandahl approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@jonrandahl jonrandahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@DanielCouzens DanielCouzens merged commit 6c3d68a into dev Oct 8, 2024
2 checks passed
@DanielCouzens DanielCouzens deleted the issue/455-ukhpi-update-ruby branch October 8, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonrandahl jonrandahl jonrandahl approved these changes

Assignees

@DanielCouzens DanielCouzens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanielCouzens @jonrandahl