Landing - Ensure links are distinguished #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomguilbert
approved these changes
Aug 6, 2024
DanielCouzens
deleted the
issue/126-landing-ensure-links-are-distinguished
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accessibility requirement mentions contrast as an issue. We only need to achieve a 3:1 contrast difference with the body text if there is no obvious visual indicator such as an underline.
I have added an underline to the link text so this accessibility requirement is now met.
Please see this paragraph on webAim
I haven't added underlines to the
English | Cymraeglanguage selection because they are not surrounded by body text.@tomguilbert do you agree that the language selection doesn't require an underline?