Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Publish Action #53

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Updated Publish Action #53

merged 5 commits into from
Aug 14, 2024

Conversation

jonrandahl
Copy link
Contributor

@jonrandahl jonrandahl commented Aug 14, 2024

  • Updated the GitHub action to reflect the revised company's gem publishing strategy
  • Removed the push trigger as gem creation needs to be a manual process
  • Reorganised and removed duplicated makefile targets
  • Introduces the use of the ${NAME} variable to increase portability of the revised makefile approach

N.B. This is marked as a release candidate in the version cadence as there is additional work needed to define a gem naming standard, port to it, and make stuff common across all public and private gems; not to mention then having to initiate releases on all applications which use this, and any other, gem that needs updated.

copied from the revised common styles gem's main action and updated to reflect the specifics for the current json rails logger publish action as well as removed the push trigger as gem creation needs to be a manual process
reorganises targets as well as introduces the use of the `${NAME}` variable to increase portability of the approach
WARNING:  open-ended dependency on `gem` (>= 0) is not recommended, use a bounded requirement, such as '~> x.y'; see https://guides.rubygems.org/specification-reference/ for help
incremented the patch digit to `4` as well as added the `.rc01` suffix
Copy link
Collaborator

@bogdanadrianmarc bogdanadrianmarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jonrandahl jonrandahl merged commit daf162b into main Aug 14, 2024
2 checks passed
@jonrandahl jonrandahl deleted the spike/update-publish-action branch August 14, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants