Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issuel #952 - Fix get_forecast_type #953

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Issuel #952 - Fix get_forecast_type #953

merged 3 commits into from
Oct 30, 2024

Conversation

nikosbosse
Copy link
Contributor

Description

This PR closes #952.

Updates the function to check for a class named forecast_ rather than only checking the first class

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@nikosbosse nikosbosse requested a review from seabbs October 28, 2024 21:18
@nikosbosse nikosbosse merged commit b96def0 into main Oct 30, 2024
9 checks passed
@nikosbosse nikosbosse deleted the fix-get_forecast_type branch October 30, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_forecast_type fails if you layer a new class on top of the forecast_type class
1 participant