Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #925 - Remove function interval_coverage_deviation() #928

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

nikosbosse
Copy link
Contributor

Description

This PR closes #925.

As discussed by me, with myself, after changing my opinion multiple times: This PR simply removes the function interval_coverage_deviation().

Users can still access its output using get_coverage() if they want - but as a standalone metric it's not that useful.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@nikosbosse nikosbosse marked this pull request as ready for review September 27, 2024 16:52
@nikosbosse nikosbosse requested a review from seabbs September 27, 2024 17:05
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And as discussed on slack. Good idea. Looks good.

@seabbs seabbs merged commit c7bc1be into main Sep 30, 2024
9 checks passed
@seabbs seabbs deleted the fix-coverage branch September 30, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Questions around interval coverage deviation
2 participants