Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#885 - Delete validate_forecast() #921

Merged
merged 1 commit into from
Sep 30, 2024
Merged

#885 - Delete validate_forecast() #921

merged 1 commit into from
Sep 30, 2024

Conversation

nikosbosse
Copy link
Contributor

Description

This PR addresses some parts of #885.

As discussed there, validate_forecast() and assert_forecast() are mostly duplicates and we don't need it anymore now that we're revalidating the forecast object every time something changes.

I suggest exporting the missing functions when addressing #746 - that gives us more clarity on which functions need exporting (because the plan is to sort all functions necessary to create a new forecast type into separate files).

[Describe the changes that you made in this pull request.]

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@nikosbosse nikosbosse requested a review from seabbs September 24, 2024 20:25
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.33%. Comparing base (ff33cc7) to head (cc8cc9d).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #921      +/-   ##
==========================================
- Coverage   99.33%   99.33%   -0.01%     
==========================================
  Files          22       22              
  Lines        1650     1648       -2     
==========================================
- Hits         1639     1637       -2     
  Misses         11       11              
Flag Coverage Δ
99.33% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seabbs seabbs enabled auto-merge (squash) September 30, 2024 20:34
@seabbs seabbs disabled auto-merge September 30, 2024 20:34
@seabbs seabbs merged commit 6b004b8 into main Sep 30, 2024
9 checks passed
@seabbs seabbs deleted the export-functions branch September 30, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants