Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR increases test coverage by
test_forecast_type_is...
functions. I think we previously used this to automagically determine the forecast type inget_forecast_type()
, but that's handled via classes now.Remaining difference between actual codecov and 100% is due to
permutation_test()
that can't actually ever be reached (I mean it could, but the way we're calling it internally it can't). It could do with some cleaning up, but I'm a tired man...plot_pit()
function has a genuine issue (see Testing: Make sure pit() and plot_pit() are correct #359). I didn't want to create a test that's technically working but ultimately wrongChecklist
lintr::lint_package()
to check for style issues introduced by my changes.