Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #530 - Clarify workflow in examples #877

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Issue #530 - Clarify workflow in examples #877

merged 1 commit into from
Jul 30, 2024

Conversation

nikosbosse
Copy link
Contributor

@nikosbosse nikosbosse commented Jul 28, 2024

Description

This PR closes #530.

As discussed in #530, this PR updates examples to use the pipe operator consistently and conform to the happy path outlined for users.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title as follows: issue-number: PR title
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • I have built the package locally and run rebuilt docs using roxygen2.
  • My code follows the established coding standards and I have run lintr::lint_package() to check for style issues introduced by my changes.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@nikosbosse nikosbosse marked this pull request as ready for review July 28, 2024 16:21
@nikosbosse nikosbosse requested a review from seabbs July 28, 2024 16:21
@seabbs seabbs enabled auto-merge (squash) July 30, 2024 10:42
Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Looks great. It feels kind of crazy that we can't use the base pipe yet / are stuck loading magrittr everywhere not sure what we can do about that though sadly.

@seabbs seabbs merged commit 6f5bc1b into main Jul 30, 2024
9 checks passed
@seabbs seabbs deleted the update-docs branch July 30, 2024 10:47
@nikosbosse
Copy link
Contributor Author

Requiring R 4.1 🤷

@seabbs
Copy link
Contributor

seabbs commented Jul 30, 2024

Maybe its nearly time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify package workflows (e.g. in examples) before release
2 participants