Bug fixes to plot_predictions()

[Bisaloo]

No description provided.

[Bisaloo]

Tests are failing because of vdiffr. When running locally, I get stroke-linecap: butt; for all lines while this is absent when rendered on GHA.

It is passing for oldrel because vdiffr automatically skips for R < 4.1.

[nikosbosse]

Thanks!
Is there a way to get vdiffr running on GH?

[nikosbosse]

Apart from the failing GHA tests looks nice!

[Bisaloo]

Could you tell me what you get when you run R CMD check locally? I guess this is more important for visual diffs. We can always skip on CI.

[nikosbosse]

First error is that I don't have vdiffr installed (it does install that on the server, right?). After installing vdiffr, I get this error:

Apparently the image is not in the correct place, but I'm not sure where it should go

[Bisaloo]

Yes, vdiffr is automatically installed (since I added it in Suggests).

The files are in the right location but you do get a different snapshot than me. If we are lucky, you are getting the same as the GitHub Actions. So could you please try to:

1. delete the tests/testthat/_snaps/ folder
2. run devtools::test()
3. commit & push the generated svg files in test/testthat/_snaps/

[codecov]

Codecov Report

Merging #153 (9cc557d) into master (29ac025) will increase coverage by 5.44%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   48.44%   53.89%   +5.44%     
==========================================
  Files          18       18              
  Lines        1348     1349       +1     
==========================================
+ Hits          653      727      +74     
+ Misses        695      622      -73     

Impacted Files	Coverage Δ
R/plot.R	20.29% <100.00%> (+20.29%)	⬆️
R/utils.R	71.42% <0.00%> (+7.93%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ac025...9cc557d. Read the comment docs.

[nikosbosse]

@Bisaloo I think that worked :)

[Bisaloo]

Amazing! I think we can merge this already if everything looks good to you.

I'll have a look at #136 later today but I'll open another PR.