We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is.logical
isTRUE
We are often checking whether the output of a check_ function is a logical. Instead, it would be cleaner to check if the value is TRUE directly.
check_
TRUE
From the code review:
This seems a bit fragile since we wouldn't want FALSE (even though it's not supposed to pop up) to return TRUE.
FALSE
test_columns_present <- function(data, columns) { check <- check_columns_present(data, columns) return(isTRUE(check)) }
Originally posted by @Bisaloo in #791 (comment)
The text was updated successfully, but these errors were encountered:
Merge pull request #815 from epiforecasts/fix-logicals
87adf45
Issue #809 - Replace is.logical by isTRUE
Successfully merging a pull request may close this issue.
We are often checking whether the output of a
check_
function is a logical. Instead, it would be cleaner to check if the value isTRUE
directly.From the code review:
Originally posted by @Bisaloo in #791 (comment)
The text was updated successfully, but these errors were encountered: