Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up schedule #15

Merged
merged 1 commit into from
Jan 12, 2023
Merged

clean up schedule #15

merged 1 commit into from
Jan 12, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jan 11, 2023

Cleans up the schedule to only run EpiNow2 for the European Forecast Hub.

@seabbs do edit if you'd like to e.g. restart nowcasting
@kathsherratt this should bring EpiNow2 case and death forecasts back to the hub. Some of the death forecasts break where cases and deaths are both reported on a weekly schedule, which EpiNow2 isn't really currently set up to deal with.

@seabbs
Copy link
Contributor

seabbs commented Jan 11, 2023

Looks good to me. Note that will need to run the setup to make sure this is working (i.e steps in the README but only this line for the forecating container)

Fingers crossed (may be a minor miracle if this works without adjustment).

Yeah, I think weekly case data will lead to some very strange results. Potentially we could mitigate by modifying the model to run on a weekly timescale (in the simple case by tricking it with dates) but not sure if worth it?

@sbfnk
Copy link
Contributor Author

sbfnk commented Jan 12, 2023

Fingers crossed (may be a minor miracle if this works without adjustment).

It seems like it's already working when running manually and is now scheduled again to run weekly.

Yeah, I think weekly case data will lead to some very strange results. Potentially we could mitigate by modifying the model to run on a weekly timescale (in the simple case by tricking it with dates) but not sure if worth it?

Possibly, although I think the better solution would be to have a latent process in the secondary model.

@sbfnk sbfnk merged commit 09a45fa into main Jan 12, 2023
@sbfnk sbfnk deleted the update-schedule branch January 12, 2023 10:15
@seabbs
Copy link
Contributor

seabbs commented Jan 12, 2023

Past Sam was a reproducibility 🧙🏻

Yes, I agree of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants