Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install future and future.apply to fix R CMD CHECK #827

Merged
merged 4 commits into from
Oct 15, 2024
Merged

Install future and future.apply to fix R CMD CHECK #827

merged 4 commits into from
Oct 15, 2024

Conversation

jamesmbaazam
Copy link
Contributor

@jamesmbaazam jamesmbaazam commented Oct 14, 2024

Description

This PR closes #826. Since #798, the future and future.apply packages were made optional but future is required to run the tests, so R CMD CHECK has been failing on main and subsequent PRs (#774, #825). This PR fixes the failing R CMD CHECK on main by installing future. It additionally installs future.apply so that it can be tested instead of using lapply().

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@jamesmbaazam jamesmbaazam requested a review from sbfnk October 14, 2024 18:43
sbfnk
sbfnk previously approved these changes Oct 15, 2024
NEWS.md Outdated Show resolved Hide resolved
@jamesmbaazam jamesmbaazam requested review from sbfnk and seabbs October 15, 2024 13:00
@sbfnk sbfnk enabled auto-merge October 15, 2024 13:18
@sbfnk sbfnk added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 9cf7ad2 Oct 15, 2024
9 checks passed
@sbfnk sbfnk deleted the fix-ci branch October 15, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R CMD check failing on main
2 participants