Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accumulate for observed reports #643

Closed
wants to merge 1 commit into from
Closed

accumulate for observed reports #643

wants to merge 1 commit into from

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Apr 30, 2024

Description

This PR closes #640. However, this revealed the complication that we don't currently have a way to set the frequency of forecasts (e.g. weekly etc). This could potentially be addressed by the suggestions in #346 (comment) and should be done first.

The suggestions in here should eventually be merged here as it makes the predictions consistent with data input.

image

Initial submission checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have tested my changes locally (using devtools::test() and devtools::check()).
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required and rebuilt docs if yes (using devtools::document()).
  • I have followed the established coding standards (and checked using lintr::lint_package()).
  • I have added a news item linked to this PR.

After the initial Pull Request

  • I have reviewed Checks for this PR and addressed any issues as far as I am able.

@seabbs
Copy link
Contributor

seabbs commented Dec 19, 2024

Is this still something that will progress or has it been replaced by the other similar work?

@sbfnk
Copy link
Contributor Author

sbfnk commented Dec 19, 2024

It has been superseded by #901 (and a subseqeunt PR to address #640).

@sbfnk sbfnk closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reported cases does not reflect the setting of accumulate
2 participants