-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directly calculated growth #610
Conversation
18760dc
to
0780ec2
Compare
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 19b5707 is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 19b5707 is merged into main:
|
8f440bd
to
a16e9bd
Compare
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3b3b2a7 is merged into main:
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 3b3b2a7 is merged into main:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup looks good. Just need a news file spelling update
Co-authored-by: Sam Abbott <[email protected]>
* switch to directly calculated growth rate * remove superseded function * add news item * avoid conversion * add skips * add test for exp(r)==R with fixed gt of 1 day * fix typo and add reviewer Co-authored-by: Sam Abbott <[email protected]> --------- Co-authored-by: seabbs <[email protected]>
* switch to directly calculated growth rate * remove superseded function * add news item * avoid conversion * add skips * add test for exp(r)==R with fixed gt of 1 day * fix typo and add reviewer Co-authored-by: Sam Abbott <[email protected]> --------- Co-authored-by: seabbs <[email protected]>
Description
This PR finishes splits out the direct growth rate calculation from #345 in order to make finishing that work more manageable. It was originally proposed in #213.
Initial submission checklist
devtools::test()
anddevtools::check()
).devtools::document()
).lintr::lint_package()
).After the initial Pull Request