Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up generation of infections #416

Merged
merged 3 commits into from
Jul 13, 2023
Merged

speed up generation of infections #416

merged 3 commits into from
Jul 13, 2023

Conversation

sbfnk
Copy link
Contributor

@sbfnk sbfnk commented Jul 4, 2023

implements suggestions from #415

@sbfnk sbfnk force-pushed the speedup-infections branch from 3e43263 to fefe19b Compare July 4, 2023 13:08
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 8929be0 is merged into main:

  •   :rocket:default: 57.2s -> 50.2s [-20.5%, -3.69%]
  •   :rocket:no_delays: 57.3s -> 50.2s [-22.78%, -1.82%]
  •   :ballot_box_with_check:random_walk: 15.6s -> 14.5s [-18.12%, +3.61%]
  •   :ballot_box_with_check:stationary: 31.9s -> 30.5s [-12.24%, +3.69%]
  •   :rocket:uncertain: 1.34m -> 1.08m [-32.49%, -6.36%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@sbfnk sbfnk marked this pull request as ready for review July 4, 2023 15:18
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

This is how benchmark results would change (along with a 95% confidence interval in relative change) if 59dae8e is merged into main:

  •   :rocket:default: 55s -> 47.4s [-25.82%, -1.69%]
  •   :ballot_box_with_check:no_delays: 56.2s -> 49.4s [-26.33%, +1.98%]
  •   :rocket:random_walk: 16.3s -> 14.3s [-21.74%, -2.55%]
  •   :rocket:stationary: 30.5s -> 29.4s [-6.44%, -0.37%]
  •   :ballot_box_with_check:uncertain: 1.17m -> 1.14m [-14.17%, +9.48%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

Copy link
Contributor

@seabbs seabbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note this may reduce stability in contexts with problematic data which were the motivation for adding these padding values.

@sbfnk
Copy link
Contributor Author

sbfnk commented Jul 6, 2023

I was wondering about that, thinking that it would have been mitigated by cd2e738 (#366) but I might be missing something.

@seabbs
Copy link
Contributor

seabbs commented Jul 6, 2023

Potentially though it was largely issues in warm-up from the likelihood vs in the generated quantities. I think given pathfinder will soon be out many of these issues with stability are likely soon to be resolved.

@sbfnk sbfnk merged commit a6c68b1 into main Jul 13, 2023
@sbfnk sbfnk deleted the speedup-infections branch July 13, 2023 13:18
seabbs added a commit that referenced this pull request Jul 14, 2023
@sbfnk sbfnk mentioned this pull request Jul 17, 2023
sbfnk added a commit that referenced this pull request Jul 17, 2023
sbfnk pushed a commit that referenced this pull request May 3, 2024
sbfnk pushed a commit that referenced this pull request May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants