Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use profile links from 'social' object #3

Closed
wants to merge 1 commit into from

Conversation

aslafy-z
Copy link

@aslafy-z aslafy-z commented May 9, 2018

While setting up this theme, I figured out that if I'm not using github social, 'site.github' where already defined by github itself. https://help.github.com/articles/repository-metadata-on-github-pages/#available-repository-metadata

I moved all social links to a 'social' object.

This PR comes in two chunks, one per branch.

@epidrome epidrome mentioned this pull request May 9, 2018
4 tasks
@epidrome
Copy link
Owner

epidrome commented May 9, 2018

nice catch, thanks! I am reluctant to change so many variables in order to fix just one bug. For example the remote theme functionality will break for many existing users, who already have a config file with site.facebook instead of the proposed site.social.facebook.

Nevertheless, I have opened an issue #5 to consider the naming-loop of social icons separately and as a whole. The theme is still in alpha so we might want to introduce major updates as long as they offer significant benefits.

thanks again for reporting this bug!

@epidrome epidrome closed this May 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants