feat: masks #4332
Merged
feat: masks #4332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m0ksem
commented
Jul 1, 2024
| @@ -0,0 +1,228 @@ | |||
| interface TokenBase { | |||
There was a problem hiding this comment.
This parser is actually good. The only problem here is in tree: Token[] type. I should've been use TokenBase[] here, because Token is declared after tree: Token[].
This also might be optimized if we parse normalized at the beginning. But it is too complex to understand.
m0ksem
commented
Jul 1, 2024
|
|
||
| type PossibleResult = RegexToken[] | ||
|
|
||
| export const normalizeTokens = (tokens: Token[], dynamic = false) => { |
There was a problem hiding this comment.
Normalization is okay... Can be improved for better readability.
m0ksem
commented
Jul 1, 2024
| return true | ||
| } | ||
|
|
||
| const formatByRegexTokens = (possibleResults: PossibleResult[], value: string, reverse = false) => { |
There was a problem hiding this comment.
This one is a mess and most likely at unoptimized.
m0ksem
commented
Jul 1, 2024
| const suggestedChar = possibleSuggestions[0]?.expect ?? '' | ||
| let canBeSuggested = possibleSuggestions.every((token) => token.expect === suggestedChar) && value[valueOffset]?.length > 0 | ||
|
|
||
| const onlyStaticLeft = possibleResults.length === 1 && possibleResults[0].slice(tokensOffset).every((token) => token.static) |
There was a problem hiding this comment.
It must be refactored.
Merged
m0ksem
added a commit
that referenced
this pull request
Jul 23, 2024
* raw * feat(masks): remove junk * feat(masks): add docs * feat(masks): improve suggestion when option group * feat(masks): add static tokens if only one possible solution is left * docs(masks): improve phone extended demo * feat(masks): correct suggestion when only one possible solution is left
m0ksem
added a commit
that referenced
this pull request
Aug 26, 2024
* raw * feat(masks): remove junk * feat(masks): add docs * feat(masks): improve suggestion when option group * feat(masks): add static tokens if only one possible solution is left * docs(masks): improve phone extended demo * feat(masks): correct suggestion when only one possible solution is left
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR originally created to replace cleavejs.
We can have it in beta state before 1.10.0