Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

907 dont skip dir listings #1192

Merged
merged 12 commits into from
Sep 14, 2024
Merged

907 dont skip dir listings #1192

merged 12 commits into from
Sep 14, 2024

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Aug 26, 2024

Landing a Pull Request (PR)

closes #1144
closes #1116
closes #907

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@epi052 epi052 merged commit 762bfc4 into main Sep 14, 2024
14 of 15 checks passed
@epi052 epi052 deleted the 907-dont-skip-dir-listings branch September 14, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant