Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ASE from submodule to pip #179

Merged
merged 5 commits into from
Sep 12, 2022
Merged

Conversation

elinscott
Copy link
Collaborator

@elinscott elinscott commented Sep 12, 2022

Now that ase-koopmans can be installed via pip, we will migrate over to using pip to install it rather than having it as a submodule.

If you are a developer and you want to modify ASE, you must now...

  1. clone ase-koopmans to a directory of your choosing
  2. within this directory, run python3 -m pip install -e . to locally install ase
  3. create branches, add commits etc.
  4. create a pull request for ase-koopmans
  5. request a review on the PR
  6. once this PR is accepted and a new release of ase-koopmans has been created, update the version number of ase-koopmans in requirements/requirements.txt

@elinscott elinscott requested a review from degennar September 12, 2022 14:22
Copy link
Collaborator

@degennar degennar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Switched to the installation mode and everything works fine! Thanks Edward!

@elinscott elinscott merged commit 9202a3c into master Sep 12, 2022
@elinscott elinscott deleted the ase_from_submodule_to_pip branch September 12, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants