-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary directory autoremoval #148
Conversation
Hello @elinscott! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-06-23 16:02:38 UTC |
…r instead of the tmpdir
…r instead of the tmpdir
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 70.70% 77.38% +6.67%
==========================================
Files 70 62 -8
Lines 5500 5037 -463
==========================================
+ Hits 3889 3898 +9
+ Misses 1611 1139 -472
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks just tested in a couple of cases and it's all good for me!
This PR adds the option
keep_tmpdirs
to theworkflow
block. If set toFalse
, then the workflow, once finished, will delete all theoutdirs
from the calculations it performed.keep_tmpdirs
isTrue
by default.This PR also changes the default value of
from_scratch
fromFalse
toTrue
, because I think this is better choice for the default.Unrelatedly, this PR also moves some old test routines from
koopmans/
intotests/
, which means they are now run as part of the test suite.