Feature: ability to skip adding source directories if the directories do not exist #511

viktor-yengovatov · 2023-07-06T18:57:26Z

By this feature non exiting source directories like kotlintestsrc are excluded from source directories.

The feature is disabled by default.

Signed-off-by: Your Real Name [email protected]

mlytvyn · 2023-07-06T19:03:10Z

Hello @viktor-yengovatov , thank you very much for your efforts and contribution!!!
It would be great if you could also update CHANGELOG.md file with something like:

## [2023.2.4]

### Features
- Added possibility to skip non-existing source directories during project import [#511](https://github.com/epam/sap-commerce-intellij-idea-plugin/pull/511)

… do not exist

mlytvyn · 2023-07-06T19:12:46Z

...m/intellij/idea/plugin/hybris/project/configurators/impl/RegularContentRootConfigurator.java

@@ -328,6 +330,10 @@ private static <P extends JpsElement> void addSourceFolderIfNotIgnored(
        @NotNull final List<File> dirsToIgnore
    ) {
        if (dirsToIgnore.stream().noneMatch(it -> FileUtil.isAncestor(it, testSrcDir, false))) {
+            final boolean ignoreEmpty = HybrisApplicationSettingsComponent.getInstance().getState().getIgnoreNonExistingSourceDirectories();


@viktor-yengovatov , what do you think if we can refactor this part slightly and pass state of the HybrisApplicationSettingsComponent to this class -> methods from the ImportProjectProgressModalWindow
by that we will get appSettings only once during import of all java modules?

variable can be declared in the public synchronized void run(@NotNull final ProgressIndicator indicator) { of the ImportProjectProgressModalWindow and then passed to createJavaModule then to configuratorFactory.getContentRootConfigurator(moduleDescriptor).configure and so on

Hello @mlytvyn
I have created separate pull request for the refactoring: #512 .
I hope it fits.

sure, just take into account different target branch, I'll also change target branch for your PR #512

mlytvyn added this to the Release 2023.2.3 milestone Jul 6, 2023

mlytvyn changed the base branch from main to release/2023.2.4 July 6, 2023 18:58

viktor-yengovatov changed the title ~~Feature: ability to skip adding source directories if the directories…~~ Feature: ability to skip adding source directories if the directories do not exist Jul 6, 2023

Feature: ability to skip adding source directories if the directories…

17f16f3

… do not exist

viktor-yengovatov force-pushed the fix/omit-empty-sources branch from d4ee3e0 to 17f16f3 Compare July 6, 2023 19:06

mlytvyn reviewed Jul 6, 2023

View reviewed changes

mlytvyn merged commit 7e8d683 into epam:release/2023.2.4 Jul 6, 2023

mlytvyn mentioned this pull request Jul 6, 2023

Refactoring: Get project state only once #512

Merged

mlytvyn modified the milestones: Release 2023.2.3, Release 2023.2.4 Jul 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: ability to skip adding source directories if the directories do not exist #511

Feature: ability to skip adding source directories if the directories do not exist #511

viktor-yengovatov commented Jul 6, 2023 •

edited

Loading

mlytvyn commented Jul 6, 2023

mlytvyn Jul 6, 2023

viktor-yengovatov Jul 6, 2023 •

edited

Loading

mlytvyn Jul 6, 2023

Feature: ability to skip adding source directories if the directories do not exist #511

Feature: ability to skip adding source directories if the directories do not exist #511

Conversation

viktor-yengovatov commented Jul 6, 2023 • edited Loading

mlytvyn commented Jul 6, 2023

mlytvyn Jul 6, 2023

Choose a reason for hiding this comment

viktor-yengovatov Jul 6, 2023 • edited Loading

Choose a reason for hiding this comment

mlytvyn Jul 6, 2023

Choose a reason for hiding this comment

viktor-yengovatov commented Jul 6, 2023 •

edited

Loading

viktor-yengovatov Jul 6, 2023 •

edited

Loading