Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #523

Merged
merged 11 commits into from
Mar 1, 2024
Merged

Update dependencies #523

merged 11 commits into from
Mar 1, 2024

Conversation

NataliaDSmirnova
Copy link
Collaborator

@NataliaDSmirnova NataliaDSmirnova commented Feb 24, 2024

Description

Update a lot of dependencies:

  • "autoprefixer": "^10.4.17",
  • "browserify": "^17.0.0",
  • "copy-webpack-plugin": "^12.0.2",
  • "cross-env": "^7.0.3",
  • "css-loader": "^6.10.0",
  • "cssnano": "^6.0.4",
  • "glob": "^10.3.10",
  • "eslint": "^8.57.0",
  • "eslint-plugin-import": "^2.29.1",
  • "express": "^4.18.2",
  • "handlebars": "^4.7.8",
  • "html-webpack-plugin": "^5.6.0",
  • "jsdoc": "^4.0.2",
  • "mini-css-extract-plugin": "^2.8.0",
  • "npm-run-all": "^4.1.5",
  • "nyc": "^15.1.0",
  • "open": "^10.0.3", (required to update util scripts to *.mjs)
  • "postcss": "^8.4.35",
  • "postcss-advanced-variables": "^3.0.1",
  • "postcss-calc": "^9.0.1",
  • "postcss-cli": "^11.0.0",
  • "postcss-import": "^16.0.1",
  • "postcss-loader": "^8.1.0",
  • "postcss-nested": "^6.0.1",
  • "postcss-scss": "^4.0.9",
  • "selenium-webdriver": "^4.18.1",
  • "sinon": "^17.0.1",
  • "sinon-chai": "^3.7.0",
  • "style-loader": "^3.3.4",
  • "stylelint": "^16.2.1", (required to turn off some default rules to keep css)
  • "stylelint-config-standard-scss": "^13.0.0",
  • "terser-webpack-plugin": "^5.3.10",
  • "webpack": "^5.90.3",
  • "webpack-dev-server": "^5.0.2"

Type of changes

  • Dependency update (non-breaking change that updates third-party packages)

Checklist

  • I have read CONTRIBUTING and CODE_OF_CONDUCT guides.
  • I have followed the code style of this project.
  • I have run yarn run ci: lint and tests pass locally with my changes.
  • I have added tests that prove my fix/feature works OR The changes do not require updated tests.
  • I have added the necessary documentation OR The changes do not require updated docs.

@NataliaDSmirnova NataliaDSmirnova marked this pull request as draft February 24, 2024 04:24
@coveralls
Copy link

coveralls commented Feb 24, 2024

Coverage Status

coverage: 25.05%. remained the same
when pulling 36387a7 on update-deps
into 25fea24 on main.

@NataliaDSmirnova NataliaDSmirnova marked this pull request as ready for review February 24, 2024 05:44
paulsmirnov
paulsmirnov previously approved these changes Feb 26, 2024
Copy link
Member

@paulsmirnov paulsmirnov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the changes, thank you for your contribution.
One question to address if you don't mind.

package.json Outdated
@@ -23,6 +23,7 @@
},
"packageManager": "[email protected]",
"resolutions": {
"nomnom": "^1.8.1"
"nomnom": "^1.8.1",
"autoprefixer": "10.4.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the reason for the resolution of autoprefixer?

  • why do we need to mention it here,
  • why don't you use ^ (caret),
  • doesn't it contradict "^10.4.17" in the lib package?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The auroprefixer's authors made the breaking change in the patch version. So the main advice is to fix the version be equal to 10.4.5 for now.
twbs/bootstrap#36259

@NataliaDSmirnova NataliaDSmirnova merged commit 02de8d9 into main Mar 1, 2024
4 checks passed
@NataliaDSmirnova NataliaDSmirnova deleted the update-deps branch March 1, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants