-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #523
Update dependencies #523
Conversation
- restore scripts: `show:*`, `jison:*`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the changes, thank you for your contribution.
One question to address if you don't mind.
package.json
Outdated
@@ -23,6 +23,7 @@ | |||
}, | |||
"packageManager": "[email protected]", | |||
"resolutions": { | |||
"nomnom": "^1.8.1" | |||
"nomnom": "^1.8.1", | |||
"autoprefixer": "10.4.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain the reason for the resolution of autoprefixer?
- why do we need to mention it here,
- why don't you use
^
(caret), - doesn't it contradict
"^10.4.17"
in the lib package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The auroprefixer's authors made the breaking change in the patch version. So the main advice is to fix the version be equal to 10.4.5 for now.
twbs/bootstrap#36259
Description
Update a lot of dependencies:
Type of changes
Checklist
yarn run ci
: lint and tests pass locally with my changes.