Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataTable missing role=table #1733

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

cpoftea
Copy link
Contributor

@cpoftea cpoftea commented Nov 7, 2023

Issue link(if exists):

Resolves #1732

Description:

Fixes DataTable missing role=table

@cpoftea cpoftea force-pushed the fix-datatable-role branch from 91e605a to ce1da35 Compare November 8, 2023 06:21
Copy link

github-actions bot commented Nov 8, 2023

Bundle size diff (in kBytes). Not gzipped. Both CSS & JS included.
Baseline: v5.1.3 (2023-09-07)
Generated by: track-bundle-size. Exceeds Limits: no
Generated at: Wed, 08 Nov 2023 17:41:55 GMT

Module Baseline Size (v5.1.3) Size Diff Within Threshold Threshold (min - max)
templateApp 987.7 940.59 -47.1 🆗 888.93 - 1086.46
@epam/app 6102.33 6266.81 +164.48 🆗 5492.09 - 6712.56
@epam/draft-rte 55.62 55.56 -0.06 🆗 50.06 - 61.18
@epam/promo 95.89 95.91 +0.01 🆗 86.3 - 105.48
@epam/uui-extra 0.21 0.21 0 🆗 0.19 - 0.24
@epam/loveship 178.96 179.54 +0.57 🆗 161.07 - 196.86
@epam/uui-components 276.58 275.06 -1.52 🆗 248.92 - 304.24
@epam/uui-core 267.2 274.29 +7.09 🆗 240.48 - 293.92
@epam/uui-db 44.47 44.47 0 🆗 40.02 - 48.92
@epam/uui-docs 101.5 101.62 +0.12 🆗 91.35 - 111.65
@epam/uui-editor 178.55 179.02 +0.46 🆗 160.7 - 196.41
@epam/uui-timeline 49.12 49.12 +0 🆗 44.21 - 54.03
@epam/uui 413.7 415.58 +1.88 🆗 372.33 - 455.07
new sizes (raw)

To set the sizes as a new baseline, you can copy/paste next content to the uui-build/config/bundleSizeBaseLine.json and commit the file.

{
  "version": "5.2.0",
  "timestamp": "2023-11-08",
  "sizes": {
    "templateApp": 963169,
    "@epam/app": 6417216,
    "@epam/draft-rte": 56892,
    "@epam/promo": 98208,
    "@epam/uui-extra": 219,
    "@epam/loveship": 183844,
    "@epam/uui-components": 281657,
    "@epam/uui-core": 280876,
    "@epam/uui-db": 45539,
    "@epam/uui-docs": 104063,
    "@epam/uui-editor": 183315,
    "@epam/uui-timeline": 50299,
    "@epam/uui": 425553
  }
}

uui-components/src/layout/ScrollBars.tsx Outdated Show resolved Hide resolved
uui-components/src/layout/ScrollBars.tsx Outdated Show resolved Hide resolved
@cpoftea cpoftea force-pushed the fix-datatable-role branch from dac8256 to c98febf Compare November 8, 2023 17:23
@cpoftea cpoftea force-pushed the fix-datatable-role branch from c98febf to 64eb21f Compare November 8, 2023 17:32
@AlekseyManetov AlekseyManetov merged commit d6cde9b into epam:develop Nov 9, 2023
2 checks passed
@AlekseyManetov
Copy link
Collaborator

@cpof-tea thanks for your contribution!

@cpoftea cpoftea deleted the fix-datatable-role branch November 9, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants