BREAKING: Add Chopper 8 support #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use `List<Interceptor>` for interceptors to support Chopper 8. Closes epam-cross-platform-lab#754
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #755 +/- ##
=======================================
Coverage 54.81% 54.81%
=======================================
Files 10 10
Lines 1268 1268
=======================================
Hits 695 695
Misses 573 573 ☔ View full report in Codecov by Sentry. |
|
This PR changes the generated Can we please get this update sometime soon? |
AnnaKandel
added a commit
to arnac-io/swagger-dart-code-generator
that referenced
this pull request
Oct 30, 2024
AnnaKandel
pushed a commit
to arnac-io/swagger-dart-code-generator
that referenced
this pull request
Nov 3, 2024
Use `List<Interceptor>` for interceptors to support Chopper 8. Closes epam-cross-platform-lab#754
AnnaKandel
pushed a commit
to arnac-io/swagger-dart-code-generator
that referenced
this pull request
Nov 3, 2024
Use `List<Interceptor>` for interceptors to support Chopper 8. Closes epam-cross-platform-lab#754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
List<Interceptor>for interceptors to support Chopper 8.This is a breaking change as the typings for interceptor are now more strict. Technically, older versions of Chopper could be supported by using
List<dynamic>instead of theIterable<dynamic>that it was but IMO it's nice to keep the types in-line with that Chopper actually expects.The example project was re-generated (which it looks like it hasn't been since #724) hence the changes to the
==operator overloads.Closes #754