Dynamic link #173
Open
Dynamic link #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ecommers/lib/core/app_services/index.dart # ecommers/lib/shared/dependency_service.dart
Platton96
reviewed
May 13, 2020
| } | ||
|
|
||
| Future _fetchProductByIdAndNavigation(int id) async { | ||
| final Product product = await productService.fetchProductById(id); |
There was a problem hiding this comment.
remove method, and move body to if (deepLink != null && membershipService.isNotExpired) {
final productId = int.parse(deepLink.queryParameters['id']);
_fetchProductByIdAndNavigation(productId);
}
Platton96
reviewed
May 13, 2020
| itunesConnectAnalyticsParameters: ItunesConnectAnalyticsParameters(), | ||
| socialMetaTagParameters: SocialMetaTagParameters( | ||
| title: '${product.details.brand} ${Formatter.getCost(product?.price)}', | ||
| description: 'best store in the world', |
There was a problem hiding this comment.
try to add into localization
Platton96
reviewed
May 13, 2020
| } | ||
|
|
||
| return null; | ||
|
|
Platton96
reviewed
May 13, 2020
| import 'package:flutter/foundation.dart'; | ||
|
|
||
| class ShareProductService { | ||
|
|
Platton96
reviewed
May 13, 2020
|
|
||
| class ShareProductService { | ||
|
|
||
| Future shareeDynamicLinkText(Product product) async { |
There was a problem hiding this comment.
rename to shareDynamicLinkText
Platton96
reviewed
May 13, 2020
| await consolidateHttpClientResponseBytes(response); | ||
| await Share.file('${product.title}', '${product.title}.png', bytes, '*/*', | ||
| text: | ||
| 'Title: ${product?.title}\nPrice: ${Formatter.getCost(product?.price)}\nRate: ${product?.rate}\n${product?.details.brand}, ${product?.details.category}'); |
There was a problem hiding this comment.
add such method in formatter with product parameter.
Platton96
reviewed
May 13, 2020
| try { | ||
| Share.text( | ||
| '${product.title}', | ||
| 'Title: ${product?.title}\nPrice: ${Formatter.getCost(product.price)}\nRate: ${product?.rate}', |
There was a problem hiding this comment.
add such method in formatter with product parameter.
There was a problem hiding this comment.
also try to use localization
Platton96
reviewed
May 13, 2020
|
|
||
| class ShareProductProviderModel extends ChangeNotifier { | ||
| Future shareDynamicLink(Product product) async { | ||
| await shareProductService.shareeDynamicLinkText(product); |
There was a problem hiding this comment.
rename shareeDynamicLinkText
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#169 closed