Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport CONFIGURABLE_WASM_LIMITS from 2.1 #8

Merged
merged 6 commits into from
Jan 17, 2022
Merged

Backport CONFIGURABLE_WASM_LIMITS from 2.1 #8

merged 6 commits into from
Jan 17, 2022

Conversation

swatanabe
Copy link
Contributor

No description provided.

@swatanabe swatanabe requested a review from tbfleming January 13, 2022 19:29
@spoonincode
Copy link
Member

Is it a requirement that this implementation match that as the 2.1 protocol feature? If not, it seems worthwhile to define a new protocol feature instead so that the fix for EOSIO/eos#10773 can be integrated

@tbfleming
Copy link
Contributor

Is it a requirement that this implementation match that as the 2.1 protocol feature?

It's not

@swatanabe
Copy link
Contributor Author

Yeah, I'll add that fix. There's another issue I'd like to fix as well (large custom sections can setcode but cannot execute), which wasn't really worth making a new protocol feature for.

@tbfleming
Copy link
Contributor

@swatanabe is it ok for me to merge this with my PR? I still need to add snapshot support and you've already ported most of what I need.

@swatanabe
Copy link
Contributor Author

@swatanabe is it ok for me to merge this with my PR? I still need to add snapshot support and you've already ported most of what I need.

Yes. I don't expect any further changes to conflict with what you're doing.

@tbfleming
Copy link
Contributor

While reviewing diffs for this I noticed that I missed bringing over the entry_db and reset_memory_fail tests when I backported eos-vm. I'll create a PR for that this week.

@swatanabe swatanabe merged commit 3e102d5 into main Jan 17, 2022
@swatanabe swatanabe deleted the wasm-config branch January 17, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants