[3.1] Add subjective limit to mod_exp host function #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds test case to test that the subjective limit is enforced.
larryk85
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on benchmarking (see fc changes for details) and a desire to prevent deadline overruns longer than 5 ms (to protect timely block delivery), we decided to enforce a subjective limit of at most 2048 bits on any of the base, exponent, or modulus.
This can be adjusted in the future (higher or lower) without a consensus change since it is a subjective limitation. In the future, we may wish to solve the above concern in a more flexible way as described in #785.
This PR also adds a test case to test that the subjective limit is enforced.