Backport cleos optional support #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set_optional Cleos support for set<optional<T>> and vector<optional<T>>
ClaytonCalabrese
suggested changes
Aug 2, 2022
Comment on lines
26
to
43
| #define SETCONTAINERVAL(x) do { \ | ||
| require_auth(user); \ | ||
| psninfoindex2 tblIndex(get_self(), get_first_receiver().value); \ | ||
| auto iter = tblIndex.find(user.value); \ | ||
| if (iter == tblIndex.end()) \ | ||
| { \ | ||
| tblIndex.emplace(user, [&](auto &row) { \ | ||
| row.key = user; \ | ||
| row.x = x; \ | ||
| }); \ | ||
| } \ | ||
| else \ | ||
| { \ | ||
| tblIndex.modify(iter, user, [&]( auto& row ) { \ | ||
| row.x = x; \ | ||
| }); \ | ||
| } \ | ||
| }while(0) |
There was a problem hiding this comment.
The spacing on this macro should be fixed up to fit our normal styling.
spoonincode
previously requested changes
Aug 3, 2022
| finally: | ||
| TestHelper.shutdown(cluster, walletMgr, testSuccessful, killEosInstances, killWallet) | ||
|
|
||
| exit(0) |
There was a problem hiding this comment.
I think this needs to check testSuccessful for the proper error code?
ClaytonCalabrese
approved these changes
Aug 3, 2022
spoonincode
dismissed
their stale review
I don't have time at the moment to do a full look over, but the one issue I mentioned before is fixed so dismissing the block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of changes to support nested optional.
Resolves: #778