[3.1] remove broad 'using namespace boost' causing float128_t conflict; fixes builds w/ boost 1.80 #702
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
abi_serializer.cpp
does aApparently something internal to boost has been reorganized and when building with boost 1.80 beta it appears this
pack_unpack<float128_t>()
is getting confused withboost::float128_t
(gets atemplate argument deduction/substitution failed
error).Remove the broad
using namespace boost
to eliminate the conflict. This is arguably a cleaner short term spot fix than #638. If accepted I will open a ticket for a more broad fix across the code base in 3.2 (likely via asoftfloat
namespace or such)